Add startup health check to prevent silent scheduler failure on non-default PORT - #665
Merged
Merged
Conversation
![its-saffron[bot]](https://avatars.githubusercontent.com/in/3901073?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…efault PORT The scheduler now calls a new `schedulerHealthCheck` function at startup which fetches `/api/health` using the configured bearer token. This verifies the scheduler can reach its own endpoints before periodic jobs begin firing. The health check returns true on HTTP 200 and false otherwise, logging descriptive errors via the injected deps.log. It does not prevent the scheduler from running — it provides visibility into misconfiguration without blocking periodic work. Fixes #653 Signed-off-by: Saffron <263493777+itsmiso-ai@users.noreply.github.com>
itsmiso-ai
force-pushed
the
foreman/wl-misospace-dispatch-653/issue-653
branch
from
July 25, 2026 11:02
3ef034c to
67cb1b4
Compare
its-saffron
Bot
dismissed
their stale review
July 25, 2026 11:08
Superseded by a newer automated review for this pull request.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Address review feedback on #665 — health check was inside the per-job loop, causing N checks at startup instead of one.
Contributor
There was a problem hiding this comment.
AI Automated Review
Full PR review.
Analysis engine: MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic) — escalated (fast_low_confidence)
Recommendation: Approve
This PR adds a startup health check to the in-app scheduler that verifies it can reach its own /api/health endpoint before arming periodic jobs. The change is minimal, well-tested, and satisfies the linked issue's acceptance criteria.
Change-by-Change Findings
src/lib/scheduler.ts (+31 lines)
schedulerHealthCheck: New exported async function that fetches${config.baseUrl}/api/healthwith bearer auth. Returnstrueon HTTP 200,falseotherwise. Uses the repository's canonicalerror instanceof Errorpattern for error handling and logs descriptive failure messages (HTTP status code or exception message).startScheduler: Injects one additionalsetTimeoutcall (at the sameconfig.startupDelayMsas job timers) to fireschedulerHealthCheckonce at startup, outside the per-job loop. The check is non-blocking — it does not prevent periodic work from arming.
src/lib/scheduler.test.ts (+42, -7 lines)
- Updates the existing
startSchedulertest to assert twosetTimeoutcalls (health check + job) and fires both callbacks before asserting. - New
describe("schedulerHealthCheck")block with three cases: happy-path 200 →true, non-ok status →falsewith log, fetch throws →falsewith log and error.
Standards Compliance
| Standard | Status |
|---|---|
Error handling — error instanceof Error pattern |
✅ Used in schedulerHealthCheck catch block |
| Bearer token auth for internal endpoints | ✅ Authorization: Bearer ${config.token} matches existing scheduler auth model |
| No secrets in logs | ✅ Only config.token used for auth header; token value not echoed |
| API returns appropriate HTTP status / JSON | ✅ schedulerHealthCheck is an internal helper, not an HTTP route; existing health route is unchanged |
| Validation before DB operations | ✅ N/A — this function makes an HTTP call, not a DB call |
Linked Issue Fit
Issue PR 653 acceptance criteria:
| Criterion | Verification |
|---|---|
Use 127.0.0.1:${port} consistently with port resolved from PORT env |
✅ schedulerConfigFromEnv (existing code) builds baseUrl as http://127.0.0.1:${port} where `port = env.PORT?.trim() |
| Add a startup health check that verifies the scheduler can reach its own endpoints | ✅ schedulerHealthCheck fires once via setTimeout at startupDelayMs (5s default) before jobs arm. It calls /api/health with bearer auth and logs failures. |
Tool Harness Findings
The harness confirmed:
src/lib/scheduler.tsandsrc/lib/scheduler.test.tsmatch the diff content.schedulerConfigFromEnvalready constructsbaseUrlcorrectly fromPORTenv (http://127.0.0.1:8080whenPORT=8080)./api/healthis listed inmiddleware.tsas always-public (no auth required), so the health check will succeed regardless of auth mode.
CI Check Results
All CI checks passed at commit c9fdc7b9e5d9b65e477d55f166d890ec0f334a6c:
- ✅ Typecheck
- ✅ Tests
- ✅ Lint
- ✅ Build
- ✅ Docker Build
Unknowns or Needs Verification
None — the diff is self-contained, the implementation is internally consistent with the existing scheduler pattern, and all acceptance criteria from the linked issue are addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes PORT resolution in the in-app scheduler to properly handle empty/whitespace values, and adds a startup health check that verifies the scheduler can reach its own
/api/healthendpoint before arming periodic jobs.Why
The scheduler previously used `env.PORT |…
Fixes #653
Opened by foreman on review GO (workload wl-misospace-dispatch-653).